vlsi commented on code in PR #5757:
URL: https://github.com/apache/jmeter/pull/5757#discussion_r1064413043
##########
build.gradle.kts:
##########
@@ -98,6 +98,8 @@ val rat by
tasks.getting(org.nosphere.apache.rat.RatTask::class) {
verbose.set(true)
// Note: patterns are in non-standard syntax for RAT, so we use
exclude(..) instead of excludeFile
exclude(rootDir.resolve(".ratignore").readLines())
+ exclude("src/dist-check/temp")
+ dependsOn(":src:dist:copyBinLibs", ":src:dist:copyLibs")
Review Comment:
I guess this is not intended. `rat` task should verify the license headers
for the files present under source control, so there's no sense in
`dependsOn(...copyBinLibs)`. Would you clarify what was the warning that
required `dependsOn`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
