vlsi commented on code in PR #5873:
URL: https://github.com/apache/jmeter/pull/5873#discussion_r1181670983
##########
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/parser/LagartoBasedHtmlParser.java:
##########
@@ -181,8 +181,6 @@ public void tag(Tag tag) {
break;
case END:
break;
- default:
Review Comment:
This is a switch over `jodd.lagarto.TagType` enum. The current switch covers
all enum cases.
I think it would be better to ensure enum switches are exhaustive rather
than fail in runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]