[GitHub] [jmeter] vlsi commented on issue #5875: Performance affected by Config Elements

[via GitHub]

vlsi commented on issue #5875:
URL: https://github.com/apache/jmeter/issues/5875#issuecomment-1533369880

   The allocation profling shows we allocate a lot of strings when 
concatenating property names in 
https://github.com/apache/jmeter/blob/b6d11d79d905d0c099732bb928d2372fd1388981/src/core/src/main/java/org/apache/jmeter/control/IteratingController.java#L49
   
   Another interesting case is 
`Integer.valueOf(IntegerProperty.getStringValue)` in 
https://github.com/apache/jmeter/blob/b6d11d79d905d0c099732bb928d2372fd1388981/src/core/src/main/java/org/apache/jmeter/control/LoopController.java#L90
   
   I think we should just replace it with `prop.getIntValue()` and avoid 
`Integer` for the field type `Integer nbLoops`.
   
   <img width="719" alt="JMeter allocation profile results showing string 
concatenation in IteratingController" 
src="https://user-images.githubusercontent.com/213894/235983532-d9b90ad3-703b-439a-b3de-504dfab93844.png";>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org