milamberspace commented on code in PR #727:
URL: https://github.com/apache/jmeter/pull/727#discussion_r1190804477
##########
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/control/HeaderManager.java:
##########
@@ -57,9 +58,19 @@ public HeaderManager() {
setProperty(new CollectionProperty(HEADERS, new ArrayList<>()));
}
+ private void assertMutable() {
+ if (isRunningVersion()) {
+ throw new IllegalStateException(
+ "Cannot modify HeaderManager " + getName() + " while test
is running. " +
+ "If you need dynamic headers, prefer using ${...}
expressions in your headers."
Review Comment:
Not sure that the functions in JMeter can be call "expression language", but
why not. if you would change to "JMeter expression language", then the manual
need to be update (remplace the terms "functions" to "JMeter expression
language"), and in JMeter self (menu Tools > Function Helper Dialog)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
