[GitHub] [jmeter] vlsi commented on pull request #5944: feat: Enable usage of ${...} expressions for checkbox controls

[via GitHub]

vlsi commented on PR #5944:
URL: https://github.com/apache/jmeter/pull/5944#issuecomment-1570005381

   I rearranged the commits, and will split them into different PRs soon.
   
   For reference, here are the changes to migrate `TestPlan` to editable 
checkboxes: 
https://github.com/apache/jmeter/pull/5944/commits/3943b08c7c20f20ef5aecca7c709d848deca3ec0
   
   ```diff
   -    private final JCheckBox serializedMode;
   +    private final JBooleanPropertyEditor serializedMode =
   +            new 
JBooleanPropertyEditor(TestPlanSchema.INSTANCE.getSerializeThreadgroups(), 
"testplan.serialized");
   
   -            tp.setSerialized(serializedMode.isSelected());
   +            serializedMode.updateElement(tp);
   
   -            serializedMode.setSelected(tp.isSerialized());
   +            serializedMode.updateUi(tp);
   
   -        serializedMode.setSelected(false);
   +        serializedMode.reset();
   ```
   
   It looks good to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org