vlsi opened a new pull request, #5984:
URL: https://github.com/apache/jmeter/pull/5984

   Historically AbstractTestElement calls default constructor in order to 
create a clone. It might be that a constructor would add properties (e.g. 
LoopController, HeaderManager), so we might get invalid clones if the clone 
source _removes_ a property which was added in the constructor.
   
   An alternative approach would be using `super.clone()`, however, it would be 
a significant change, so for now I suggest just removing "extra" properties 
that might be accidentally added in constructor.
   
   The visible effect was that `LoopController` was unequal after cloning if 
user removes `continueForever` property from the `LoopController`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to