junyejiang commented on PR #6406: URL: https://github.com/apache/jmeter/pull/6406#issuecomment-2647157485
> I have not checked the way the report works, however, I have a few comments: > > 1. Have you checked `sampleresult.useNanoTime` JMeter property? If so could you describe why the property is not enough for you? > 2. Please refrain from modifying the existing tests. In most cases, if you modify an existing test it means you break backward compatibility which is unwanted. > 3. Please create new tests for the feature you add > 4. Please refrain from combining multiple unrelated changes into a single commit. I think the change of `double` -> `BigDecimal` should be discussed and measured separately 1. Yes I did tried `sampleresult.useNanoTime`, and finally find out that report was still in ms, this property will not help. 2 & 3. My PR do break backwark compatibility, as the former JTL file was stored in ms format, My PR will change it to ns format. So that the former tests wold not pass until updated. 4. Changes in calculators from Long to BigDecimal is because, firstly every test timestamp is 1 million bigger than before so Long could be easily overflow during accumulation; secondly BigDecimal/BigInteger is more precise than Long in calculation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
