vlsi commented on code in PR #6510:
URL: https://github.com/apache/jmeter/pull/6510#discussion_r2417631109
##########
src/core/src/main/java/org/apache/jmeter/util/JSR223TestElement.java:
##########
@@ -357,6 +355,8 @@ public void testEnded() {
*/
@Override
public void testEnded(String host) {
+ if (COMPILED_SCRIPT_CACHE.estimatedSize() > 0)
+ logger.info("Compiled cache size: {}, stats: {}",
COMPILED_SCRIPT_CACHE.estimatedSize(), COMPILED_SCRIPT_CACHE.stats());
Review Comment:
Please add braces. We do use them, however, the check was missing:
https://github.com/apache/jmeter/pull/6516
##########
xdocs/usermanual/properties_reference.xml:
##########
@@ -1985,6 +1985,10 @@ JMETER-SERVER</source>
Used by JSR-223 elements.<br/>
Size of compiled scripts cache.<br/>
Defaults to: <code>100</code></property>
+ <property name="jsr223.compiled_scripts_cache_spec">
+ Used by JSR-223 elements.<br/>
+ Caffeine framework spec configuration in String format. Overrides
<code>jsr223.compiled_scripts_cache_size</code><br/>
+ Defaults to:
<code>maximumSize=<jsr223.compiled_scripts_cache_size>,recordStats</code></property>
Review Comment:
Can you refer the documentation or copy the relevant bits here?
##########
src/core/src/main/java/org/apache/jmeter/util/JSR223TestElement.java:
##########
@@ -357,6 +355,8 @@ public void testEnded() {
*/
@Override
public void testEnded(String host) {
+ if (COMPILED_SCRIPT_CACHE.estimatedSize() > 0)
+ logger.info("Compiled cache size: {}, stats: {}",
COMPILED_SCRIPT_CACHE.estimatedSize(), COMPILED_SCRIPT_CACHE.stats());
Review Comment:
I'm not sure the stats are actionable. The stats do not seem to help users
to identify the offending elements.
What are the units for "Compiled cache size"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
