FSchumacher commented on PR #6680: URL: https://github.com/apache/jmeter/pull/6680#issuecomment-4125494396
OK, I tested locally. * the docs folder is present and can be used locally * the locally displayed docs try to find three files locally, which are not preset: merriweather.css, fontawesome.min.css and brands.min.css * if I start jmeter with `-Phelp.local=true` the internal help viewer starts with the docs contents and has problems displaying that content (as expected) * if I start jmeter in WSL as GUI, I would have to either install a linux browser, or search for other ways to get the windows browser opened from within the linux JVM. So, yes, we can merge this PR, but we still have things on our todo list (can be done after merging). * get rid of the help.local=true code path * maybe document the WSL step (can probably wait until we get the first real reported issue?) or * find a way to start the Windows Browser from within the linux JVM running in WSL gui mode * either distribute the missing files (is that possible with the ASF 2 license?) or * remove the links in the local version or * replace it with some ASF 2 compatible license or * ignore it for now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
