e345ee commented on code in PR #6726:
URL: https://github.com/apache/jmeter/pull/6726#discussion_r3603224753
##########
src/components/src/main/java/org/apache/jmeter/config/CSVDataSet.java:
##########
@@ -239,7 +239,11 @@ private static void trimVarNames(String[] varsNames) {
* @return Returns the filename.
*/
public String getFilename() {
- return filename;
+ if (filename != null) {
+ return filename;
+ }
+ JMeterProperty property = getPropertyOrNull("filename");
Review Comment:
Thanks for the review.
I added the required `xdocs/changes.xml` bug-fix entry and added myself
under `Thanks`.
I also addressed the non-blocking scope note in this PR: the sibling
`CSVDataSet` configuration getters now use the same property-map fallback
pattern after `SaveService.loadTree()`. Explicit setters still take precedence
over fallback values, including `null` for string properties and `false` for
boolean properties.
Tested with:
- `./gradlew --no-daemon --max-workers=2 :src:components:test --tests
org.apache.jmeter.config.TestCVSDataSet`
- `./gradlew --no-daemon --max-workers=2 :src:components:checkstyleMain
:src:components:checkstyleTest`
- `git diff --check`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
