vlsi commented on PR #6771: URL: https://github.com/apache/jmeter/pull/6771#issuecomment-5822750707
Thanks for looking into this. I'm closing the PR because the change goes in the wrong direction. Here is why. **The `true` default is intentional.** `jmeter.save.saveservice.url` became `true` in JMeter 5.0, in b65d536d49 (Bug 62550). The same commit changed `bin/jmeter.properties` to `#jmeter.save.saveservice.url=true` and added `# Since JMeter 5.0, defaults for this property is true` to `bin/testfiles/jmeter-batch.properties`. Only the documentation was not updated: `properties_reference.xml` and `listeners.xml` still say `false`. So the mismatch should be fixed in the docs, not in the code. **Changing the default breaks existing setups.** Anyone who writes CSV results with `-l` and no override would lose the `URL` column. Tools that read the CSV by column position would break without any error. `jmeter -g` would also misread a CSV without a header (`print_field_names=false`) written by 5.x, because `CsvSampleReader` builds the column list from the current defaults. `testHeader` and `testSample` in `TestCSVSaveService` exist to catch this kind of change, and their comment asks to check whether the default was changed on purpose. **The PR does not fix #6395.** The issue reports that the URL is written even with `jmeter.save.saveservice.url=false` in `user.properties`. When the property is set, the code default is not used at all. The URL comes from the listener: Summary Report stores its `SampleSaveConfiguration` in the .jmx file, and a listener created while the default was `true` has `<url>true</url>` there. The setting in the test plan wins over the `jmeter.save.saveservice.*` properties, so that listener writes the URL until "Save URL" is unticked in its Configure dialog (Sample Result Save Configuration). I'm leaving #6395 open for that. **The workflow change belongs in a separate PR.** `gradle/actions/[email protected]` is indeed no longer on the ASF allowlist. However, v6.2.0 is listed there with `expires_at: 2026-10-30`, and v6.3.0 (`9c971963bec38e04b3d30dcc455b5382be2fdbfb`) has no expiry date. I'll update the workflow separately. If you want to follow up, a PR that updates `properties_reference.xml` and `listeners.xml` to say the default has been `true` since 5.0 would be welcome. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
