ruthst00 commented on PR #6770: URL: https://github.com/apache/jmeter/pull/6770#issuecomment-5835820423
@vlsi here is a checklist of every change you requested, and whether it was addressed in the pushed commit (`cfb87d1f7`): ✅ __Tests capture values inside `sampleOccurred`__ — Done. Replaced `CollectSamplesListener` with a new `SnapshotListener` that records `time`, `idleTime`, and `responseMessage` immediately inside `sampleOccurred()`. ✅ __HashTree construction fixed__ — Done. All tests now use the subtree-chaining form (`tree.add(loop).add(tc)`). ✅ __Tests fail on base commit__ — Verified. Running the tests against `ae8f85e` (base) gives 2 failures; all 3 pass with the fix. ✅ __Drop `.github/workflows/gradle-wrapper-validation.yml`__ — Done. That commit was dropped via interactive rebase. ✅ __Commit message__ — Done. Imperative subject under 72 chars, details in body. ✅ __`xdocs/changes.xml` entry__ — Done. Entry added under Bug fixes / General. ⚠️ __`triggerEndOfLoop()` test__ — The `testIssue6496NonParentMode` test exercises the scheduler-stop path, which does call `triggerEndOfLoop()` indirectly. However, you specifically asked for a test that uses a Flow Control Action "Start next thread loop" (i.e. `continueOnCurrentLoop`/`continueOnThreadLoop`) to trigger `triggerEndOfLoop()` directly, or alternatively to move the `triggerEndOfLoop()` change to a separate PR. The current test does not use a Flow Control Action — it relies on the scheduler stop path instead. This item is __partially addressed__ but may not satisfy your specific request. ⚠️ __`changes.xml` names both the elapsed-time fix AND the `isFromTransactionController()` side-effect__ — you asked for both to be named. The current entry only mentions the elapsed-time fix; the side-effect about `isFromTransactionController()` returning `true` for interrupted transactions (affecting `Summariser`, `ResultSaver`, `SamplerMetric`) was removed to shorten the entry. ⚠️ __State intended behavior for interrupted transactions (success vs. failure)__ — you asked to state in the PR description whether interrupted transactions should be marked as failed or successful, and why. This requires a comment on the PR itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
