rebelwithoutacause opened a new pull request, #6831: URL: https://github.com/apache/jmeter/pull/6831
### Description `:src:dist-check:batchServerBatchTestLocal` fails intermittently on slow runners — every recent failure of the CI workflow on `master` and on unrelated PRs is a macOS matrix entry failing this task (e.g. runs 36885805256, 36881271396, 39191681575). #6674 reports the same failure on s390x. ### Root cause `BatchTestLocal.jmx` runs 2 threads with a 10 s ramp-up, so thread 2 starts ~5 s in, and the golden files assume thread 1 has finished by then. On slow runners its last samples overlap thread 2's start and record 2 active threads. The CI diff shows only `grpThreads`/`allThreads` (CSV) and `ng`/`na` (XML) changing from 1 to 2; labels, counters and row order are identical. `BatchTest.kt` compares byte-for-byte, so the task fails. ### Changes 1. Set `<threadCounts>false</threadCounts>` on all 18 result collectors in `BatchTestLocal.jmx` (each thread group has its own CSV/XML writers targeting the same two files). 2. Raise the main thread group's `ramp_time` from 10 s to 20 s, doubling the margin before thread 2 starts. It is the only multi-threaded group; the others have 1 thread and are serialized. 3. Remove the thread-count fields from `BatchTestLocal.csv` / `.xml`. No other content changes. ### Testing - `./gradlew :src:dist-check:batchBatchTestLocal :src:dist-check:batchServerBatchTestLocal` passes locally (JDK 21, Windows); server mode passed 3 consecutive reruns. - Each batch run takes ~11 s instead of ~6 s due to the longer ramp-up. - **CI on fork:** https://github.com/rebelwithoutacause/jmeter_/actions/runs/39911287011 — `batchBatchTestLocal` and `batchServerBatchTestLocal` passed on all macOS jobs across both attempts. The first attempt hit two unrelated flakes (`batchTestSchedulerWithTimer` duration check at 7262 ms vs 7000 ms, and a `docs.oracle.com` DNS failure in `:src:functions:javadoc`); both passed on re-run. ### Limitations The test is still timing-based. With forced heavy overlap (`ramp_time` = 1 s) the server-mode run failed 3 of 4 times because thread interleaving changes row order, which no output setting can mask. This PR removes the failure mode seen in CI and widens the margin; a fully deterministic test would need the plan restructured. Happy to do that if preferred. Fixes #6674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
