[
https://issues.apache.org/jira/browse/JOHNZON-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358147#comment-17358147
]
Romain Manni-Bucau commented on JOHNZON-347:
--------------------------------------------
Hi [~christoph.dreis],
think a quick fix can be to set `.setDeduplicateObjects(false)` on the mapper
config (or same on JSON-B config properties).
I suspect a quick fix can be to test and return null if
java.util.Arrays$ArrayList is passed to
org.apache.johnzon.mapper.Mappings#doFindOrCreateClassMapping without even
looking into classes map.
A longer fix can be to drop this isDedup check in
org.apache.johnzon.mapper.Mapper#writeObjectWithGenerator since it is not the
right place (should be checked only when the mapping is obtained, already
mentionned it to [~struberg] on slack so we can fix it in 2 passes, one with
the quick fix to do a 1.2.14 and let it go out quickly and a more robust fix
after.
Hope it makes sense.
Romain
> Mapper.writeArray() fails on JDK 17
> -----------------------------------
>
> Key: JOHNZON-347
> URL: https://issues.apache.org/jira/browse/JOHNZON-347
> Project: Johnzon
> Issue Type: Bug
> Components: Mapper
> Affects Versions: 1.2.13
> Reporter: Christoph Dreis
> Priority: Critical
>
> Hi,
> I've noticed that Mapper.writeArray fails on JDK 17 due to
> [https://openjdk.java.net/jeps/403] strongly encapsulating internals now. To
> reproduce just run `JohnzonJsonbTest` with JDK 17 (build 25 at least to
> include JEP 403). You will see stacktraces like the following:
> ```
> java.lang.reflect.InaccessibleObjectException: Unable to make field private
> final java.lang.Object[] java.util.Arrays$ArrayList.a accessible: module
> java.base does not "opens java.util" to unnamed module
> @4361bd48java.lang.reflect.InaccessibleObjectException: Unable to make field
> private final java.lang.Object[] java.util.Arrays$ArrayList.a accessible:
> module java.base does not "opens java.util" to unnamed module @4361bd48
> at
> java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354)
> at
> java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297)
> at java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:178)
> at java.base/java.lang.reflect.Field.setAccessible(Field.java:172) at
> org.apache.johnzon.mapper.access.FieldAccessMode$FieldDecoratedType.<init>(FieldAccessMode.java:105)
> at
> org.apache.johnzon.mapper.access.FieldAccessMode$FieldReader.<init>(FieldAccessMode.java:169)
> at
> org.apache.johnzon.mapper.access.FieldAccessMode.doFindReaders(FieldAccessMode.java:49)
> at
> org.apache.johnzon.mapper.access.BaseAccessMode.findReaders(BaseAccessMode.java:82)
> at
> org.apache.johnzon.mapper.access.FieldAndMethodAccessMode.doFindReaders(FieldAndMethodAccessMode.java:68)
> at
> org.apache.johnzon.mapper.access.BaseAccessMode.findReaders(BaseAccessMode.java:82)
> at
> org.apache.johnzon.jsonb.JsonbAccessMode.findReaders(JsonbAccessMode.java:468)
> at
> org.apache.johnzon.mapper.access.KnownNotOpenedJavaTypesAccessMode.findReaders(KnownNotOpenedJavaTypesAccessMode.java:182)
> at org.apache.johnzon.mapper.Mappings.createClassMapping(Mappings.java:475)
> at
> org.apache.johnzon.mapper.Mappings.doFindOrCreateClassMapping(Mappings.java:437)
> at
> org.apache.johnzon.mapper.Mappings.findOrCreateClassMapping(Mappings.java:411)
> at org.apache.johnzon.mapper.Mapper.isDeduplicateObjects(Mapper.java:202) at
> org.apache.johnzon.mapper.Mapper.writeObjectWithGenerator(Mapper.java:196) at
> org.apache.johnzon.mapper.Mapper.writeObject(Mapper.java:189) at
> org.apache.johnzon.mapper.Mapper.writeObject(Mapper.java:217) at
> org.apache.johnzon.mapper.Mapper.writeArray(Mapper.java:104) at
> org.apache.johnzon.jsonb.JohnzonJsonb.toJson(JohnzonJsonb.java:390)
> ```
> I didn't find a quick way to fix this, but let me know if I can help.
>
> Cheers,
> Christoph
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
