csaboka commented on a change in pull request #74:
URL: https://github.com/apache/johnzon/pull/74#discussion_r667305236
##########
File path:
johnzon-core/src/main/java/org/apache/johnzon/core/JohnzonJsonParserImpl.java
##########
@@ -134,18 +140,57 @@ public void skipArray() {
@Override
public Stream<JsonValue> getArrayStream() {
- //X TODO this implementation is very simplistic
- //X I find it unintuitive what the spec intends here
- //X we probably need to improve this
- return getArray().stream();
+ Event current = current();
+ if (current != Event.START_ARRAY) {
+ throw new IllegalStateException(current + " doesn't support
getArrayStream()");
+ }
+
+ Spliterator<JsonValue> arraySpliterator = new
Spliterators.AbstractSpliterator<JsonValue>(
Review comment:
It needs to reference the enclosing parser instance, though, because it
is calling methods on that instance like `next()`. If `tryAdvance` is factored
out into a lambda, it will still capture `this`. As far as I can tell, a lambda
won't help anything in this situation. It either needs to stay a nonstatic
class like it is now, or it can be turned into a static class, but instances of
that static class will need to explicitly reference the parser they came from.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
