jeanouii commented on code in PR #110:
URL: https://github.com/apache/johnzon/pull/110#discussion_r1351694347
##########
johnzon-core/src/main/java/org/apache/johnzon/core/JsonGeneratorImpl.java:
##########
@@ -449,8 +449,8 @@ public void close() {
try {
if (ex == null) {
flushBuffer();
+ writer.close();
Review Comment:
We can't challenge the TCK. The javadoc clearly says it
https://jakarta.ee/specifications/jsonp/2.1/apidocs/jakarta.json/jakarta/json/stream/jsongenerator#close()
> The underlying stream is closed only if complete JSON object is written.
In case of incomplete object JsonGenerationException is thrown and underlying
stream is not closed.
We can create an issue to fix the specification and therefor fix the TCK
accordingly. But as per the current specification version, the challenge would
be invalid. I have no idea what was the reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
