rmannibucau commented on PR #125: URL: https://github.com/apache/johnzon/pull/125#issuecomment-2020371109
Hmm I'm not sure of this part. > Anyways, I see no real advantage of running pluggability tests if we don't have a jsonp-api module We decided to inherit from the official one so we do have it, the point of these tests is to ensure you don't break the API impl on that part - this is more obvious for containers which could hardcode the SPI or prevent the pluggability - it is often togglable like in TomEE. But long story short we should run it even if we fake the env for these tests to show our impl does not prevent it and does not break it, nothing more IMHO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
