tempted to do the classical answer: if no need not sure we should but also no strong reason to not do. I do not recall what Eclipse project decided but at some point they wanted to target 21 bypassing 17 so we might skip 17 and go to 21 too (but not yet, 11 and 17 are still too much there IMHO).
just my 0.5 cts Romain Manni-Bucau @rmannibucau <https://x.com/rmannibucau> | .NET Blog <https://dotnetbirdie.github.io/> | Blog <https://rmannibucau.github.io/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <https://www.packtpub.com/en-us/product/java-ee-8-high-performance-9781788473064> Le mer. 2 juil. 2025 à 22:17, Jean-Louis Monteiro <[email protected]> a écrit : > Yes, that was because of the version update to the next snapshot. And by > mistake that commit was pushed as well. > I reverted it and I'm checking the build. > > To me, the initial question remains valid. Should we now update to > something newer like JDK17? > I can revert my test and only leave the fix or convert my test using > Johnzon record annotations but I'm not sure it's relevant. > > I'll push my fix for now to main and leave the PR open until we discuss the > Java update or not > > -- > Jean-Louis Monteiro > http://twitter.com/jlouismonteiro > http://www.tomitribe.com > > > On Wed, Jul 2, 2025 at 10:13 PM Romain Manni-Bucau <[email protected]> > wrote: > > > guess you pushed some commit on master before creating the branch > > > > we're not releasing tomorrow so you can sleep before fixing ;) > > > > Romain Manni-Bucau > > @rmannibucau <https://x.com/rmannibucau> | .NET Blog > > <https://dotnetbirdie.github.io/> | Blog <https://rmannibucau.github.io/ > > > > | Old > > Blog <http://rmannibucau.wordpress.com> | Github > > <https://github.com/rmannibucau> | LinkedIn > > <https://www.linkedin.com/in/rmannibucau> | Book > > < > > > https://www.packtpub.com/en-us/product/java-ee-8-high-performance-9781788473064 > > > > > > > > > Le mer. 2 juil. 2025 à 22:12, Jean-Louis Monteiro < > > [email protected]> > > a écrit : > > > > > I'm sorry, I just checked my PR and it's still there, but for some > > reason I > > > pushed to my branch and to master. > > > I need to fix this quickly > > > > > > -- > > > Jean-Louis Monteiro > > > http://twitter.com/jlouismonteiro > > > http://www.tomitribe.com > > > > > > > > > On Wed, Jul 2, 2025 at 10:08 PM Jean-Louis Monteiro < > > > [email protected]> wrote: > > > > > > > Did I push to master? > > > > > > > > -- > > > > Jean-Louis Monteiro > > > > http://twitter.com/jlouismonteiro > > > > http://www.tomitribe.com > > > > > > > > > > > > On Wed, Jul 2, 2025 at 10:01 PM Romain Manni-Bucau < > > > [email protected]> > > > > wrote: > > > > > > > >> FYI you do not need to break master build increasing checkstyle nor > > > adding > > > >> "record" for tests only (which breaks some IDE) because you can > > > reproduce > > > >> it with a @JohnzonRecord > > > >> > > > >> Guess we either have to drop java 17 for test classes or upgrade > > > >> checkstyele now master is broken > > > >> > > > >> Romain Manni-Bucau > > > >> @rmannibucau <https://x.com/rmannibucau> | .NET Blog > > > >> <https://dotnetbirdie.github.io/> | Blog < > > > https://rmannibucau.github.io/> > > > >> | Old > > > >> Blog <http://rmannibucau.wordpress.com> | Github > > > >> <https://github.com/rmannibucau> | LinkedIn > > > >> <https://www.linkedin.com/in/rmannibucau> | Book > > > >> < > > > >> > > > > > > https://www.packtpub.com/en-us/product/java-ee-8-high-performance-9781788473064 > > > >> > > > > >> > > > >> > > > >> Le mer. 2 juil. 2025 à 19:27, Jean-Louis Monteiro < > > > >> [email protected]> > > > >> a écrit : > > > >> > > > >> > There it is > > > >> > > > > >> > https://github.com/apache/johnzon/pull/132 > > > >> > -- > > > >> > Jean-Louis Monteiro > > > >> > http://twitter.com/jlouismonteiro > > > >> > http://www.tomitribe.com > > > >> > > > > >> > > > > >> > On Wed, Jul 2, 2025 at 5:32 PM Jean-Louis Monteiro < > > > >> > [email protected]> > > > >> > wrote: > > > >> > > > > >> > > One more thing > > > >> > > > > > >> > > I'd like to change the visibility of the Default visibility of > > > >> Johnson. > > > >> > So > > > >> > > we can inherit from it instead of starting from scratch > > > >> > > > > > >> > > -- > > > >> > > Jean-Louis Monteiro > > > >> > > http://twitter.com/jlouismonteiro > > > >> > > http://www.tomitribe.com > > > >> > > > > > >> > > Le mer. 2 juil. 2025, 12:50, Jean-Louis Monteiro < > > > >> > [email protected]> > > > >> > > a écrit : > > > >> > > > > > >> > >> Hi all, > > > >> > >> > > > >> > >> Anyone against bumping the java version for the main branch > from > > 11 > > > >> to > > > >> > 14 > > > >> > >> (or even 17)? > > > >> > >> Currently, Java Record aren't really well managed and I don't > > think > > > >> > using > > > >> > >> Java Reflection to workaround the Java version is the best > > design. > > > >> > >> > > > >> > >> > > > >> > >> -- > > > >> > >> Jean-Louis Monteiro > > > >> > >> http://twitter.com/jlouismonteiro > > > >> > >> http://www.tomitribe.com > > > >> > >> > > > >> > > > > > >> > > > > >> > > > > > > > > > >
