Le 21 avr. 2015 22:51, "Hendrik Dev" <[email protected]> a écrit : > > A few thoughts and questions on > > JsonProvider.doLoadProvider(): > - "tccl" can be null (in case of system classloader) but thats never > really checked
If so johnzon cant be loaded isnt it? So not a big deal imo > - special handling org.apache.geronimo.osgi.locator.ProviderLocator > really needed here? > In G spec jars yes. > JsonProvider.provider(): > - doPrivileged/SecurityManager check really needed here? For containers yes and doesnt hurt at runtime normally. > - method seems thread safe but we do not cache the returned provider > instance. Maybe we can to this in a thread local variable? > Not cached for container case + i dont expect it to be called often. Thread local would break ears or wars if johnzon is in one war, jackson in another and api in the container for instance + it would leak on undeploy. Did you hit any issue? > Thanks > Hendrik > > -- > Hendrik Saly (salyh, hendrikdev22) > @hendrikdev22 > PGP: 0x22D7F6EC
