Discussed a bit with Mark offline and think the solution can be: - default profile requires j8 - release profile requires toolchain
wdyt? Romain Manni-Bucau @rmannibucau | Blog | Github | LinkedIn | Tomitriber 2016-03-25 15:02 GMT+01:00 Hendrik Dev <[email protected]>: > same question goes for jsonp 1.1 work, currently its in a separate > branch but i think we should align this with the choosen approach for > jsonb. > > On Sun, Mar 20, 2016 at 6:57 PM, Romain Manni-Bucau > <[email protected]> wrote: >> 2016-03-18 14:03 GMT+01:00 Mark Struberg <[email protected]>: >>> hi folks! >>> >>> Currently our main delivery is still EE7, right? Means we need to compile >>> with Java7, isn’t? >>> >>> But the jsonb-api requires Java8. This might cause some nasty binary >>> incompatibility issues. >>> >>> We now basically have 3 options to handle this: >>> >>> 1.) Create a new branch for the upcoming EE8 work >>> 2.) Use the maven toolchain to separate between java7 and java8 modules. >>> 3.) move the whole json-b stuff to a maven profile. >>> >>> I’d prefer 2.) It’s a bit more work to set it up, but it really works fine >>> in practice [1]. >>> >>> Any ideas? >>> >> >> 4) move jsonb to a subproject >> >> Toolchain needs a setup so kills by design contributions and easiness >> for not regular committers to contribute. Not a fan of it. If you want >> to mix mix 2 and 3 (ie default run needs j8 only and releases >> toolchain) it works for me. >> >>> >>> LieGrue, >>> strub >>> >>> [1] https://maven.apache.org/plugins/maven-toolchains-plugin/ >>> > > > > -- > Hendrik Saly (salyh, hendrikdev22) > @hendrikdev22 > PGP: 0x22D7F6EC
