Github user fhieber commented on the pull request: https://github.com/apache/incubator-joshua/commit/76eb9587a9c321d45a9560481429e2dffd918e4e#commitcomment-17618411 In src/joshua/decoder/ff/tm/hash_based/MemoryBasedBatchGrammar.java: In src/joshua/decoder/ff/tm/hash_based/MemoryBasedBatchGrammar.java on line 130: We could think about making these type strings an enum at some point to clearly define what they are.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---