Github user mjpost commented on the pull request:
https://github.com/apache/incubator-joshua/commit/19aadf0e240acb09c5b4336068e6368083f26bef#commitcomment-17620834
In src/joshua/decoder/Decoder.java:
In src/joshua/decoder/Decoder.java on line 515:
Yes, builder is a more appropriate design name, will rename. I also like
the with*() naming.
And yes, that's more logically sensible and contained. I'll give it a whirl
and see if it passes the regression tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
