[ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15302465#comment-15302465
 ] 

ASF GitHub Bot commented on JOSHUA-252:
---------------------------------------

Github user lewismc commented on the pull request:

    https://github.com/apache/incubator-joshua/pull/12#issuecomment-221933542
  
    Hi @mjpost thanks for response
    ```
    Do you want me to be the one to merge master into JOSHUA-252? Then we can 
test and merge back into master. I think this might be our 6.1 release?
    ```
    Yes please if you could take care of merging your work on master into 
JOSHUA-252 then that would be grand. I am not overly familiar with the work 
done so I don't want to botch it. Thanks Matt.
    
    ```
    Is it possible to have Maven do git checkouts (on specific versions?) 
That's one route
    ```
    I was thinking the exact same thing and I am actively investigating here. 
    ```
    Otherwise, we should just rely on the user to set them up. The only real 
problem is for BerkeleyLM and KenLM, since those are runtime. I don't have much 
experience in how to do this. But we could have a maven target that does a git 
checkout of a specific version, kind of like a submodule.
    ```
    Hopefully I can provide insight and input into this. Give me a wee bit of 
time and I can get around to answering in due course. 
    ```
    Thrax and GIZA (and fast_align) we can tell the user to set up.
    ```
    Agreed. I sent a PR for Thrax (which is incomplete due to changes in the 
underlying API) which Mavenies the entire build 
https://github.com/joshua-decoder/thrax/pull/12 we could then pull Thrax as a 
dependency within Joshua.
    For GIZA we will get the user to set up.
    
    Thanks


> Make it possible to use Maven to build Joshua
> ---------------------------------------------
>
>                 Key: JOSHUA-252
>                 URL: https://issues.apache.org/jira/browse/JOSHUA-252
>             Project: Joshua
>          Issue Type: Improvement
>          Components: build
>            Reporter: Tommaso Teofili
>            Assignee: Tommaso Teofili
>             Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to