Github user fhieber commented on the pull request:

    
https://github.com/apache/incubator-joshua/commit/6d2213a20b74432fc7cb131c732f7507b74053e9#commitcomment-17928740
  
    In src/main/java/org/apache/joshua/decoder/StructuredTranslation.java:
    In src/main/java/org/apache/joshua/decoder/StructuredTranslation.java on 
line 57:
    Hi matt,
    
    Do you need the features member of structuredTranslation to be a 
FeatureVector? The problem is that this leaks IDs of features into downstream 
applications. 
    
    Cheers,
    Felix


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to