[ https://issues.apache.org/jira/browse/JOSHUA-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15420020#comment-15420020 ]
ASF GitHub Bot commented on JOSHUA-294: --------------------------------------- GitHub user maxthomas opened a pull request: https://github.com/apache/incubator-joshua/pull/38 JOSHUA-294 - Remove CommandLineParser class Removes CommandLineParser class which was untested and unused, and similar to ArgsParser, which is actually used. You can merge this pull request into a Git repository by running: $ git pull https://github.com/maxthomas/incubator-joshua JOSHUA-294 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-joshua/pull/38.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #38 ---- commit fcaf0bf8e4ad487ee26c5276ddbecd0ef323eed7 Author: Max Thomas <m...@maxthomas.io> Date: 2016-08-13T17:59:51Z JOSHUA-294 - Remove CommandLineParser class, which was untested and unused, and similar to ArgsParser, which is actually used. ---- > Remove CommandLineParser class > ------------------------------ > > Key: JOSHUA-294 > URL: https://issues.apache.org/jira/browse/JOSHUA-294 > Project: Joshua > Issue Type: Improvement > Reporter: Max Thomas > Priority: Trivial > Original Estimate: 5m > Remaining Estimate: 5m > > The CommandLineParser class is a couple hundred of lines of untested code, > with inner classes, that is never called anywhere else in the project. > Perhaps it should be removed, especially given its similarity to ArgsParser > in the decoder package. -- This message was sent by Atlassian JIRA (v6.3.4#6332)