[
https://issues.apache.org/jira/browse/JOSHUA-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15426112#comment-15426112
]
Hudson commented on JOSHUA-291:
-------------------------------
SUCCESS: Integrated in Jenkins build joshua_master #92 (See
[https://builds.apache.org/job/joshua_master/92/])
JOSHUA-291 - static analysis based code improvements on adagrad package
(tommaso: rev 233818d6ce526f3a77b33110d67314b723371743)
* (edit) src/main/java/org/apache/joshua/adagrad/Optimizer.java
* (edit) src/main/java/org/apache/joshua/adagrad/AdaGradCore.java
JOSHUA-291 - static analysis based code improvements on corpus package
(tommaso: rev 356b173d4fa3f0efa4ea53809e46c9e04c8c1ca5)
* (edit) src/main/java/org/apache/joshua/corpus/SymbolTable.java
* (edit) src/main/java/org/apache/joshua/corpus/Span.java
* (edit) src/main/java/org/apache/joshua/corpus/Phrase.java
* (edit) src/main/java/org/apache/joshua/corpus/ContiguousPhrase.java
* (edit) src/main/java/org/apache/joshua/corpus/Vocabulary.java
* (edit) src/main/java/org/apache/joshua/corpus/syntax/ArraySyntaxTree.java
* (edit) src/main/java/org/apache/joshua/corpus/syntax/SyntaxTree.java
* (edit) src/main/java/org/apache/joshua/corpus/BasicPhrase.java
JOSHUA-291 - static analysis based code improvements on decoder package
(tommaso: rev 029cbbcc156d4939ebe503cc58962ab24728f653)
* (edit) src/main/java/org/apache/joshua/decoder/ff/SourceDependentFF.java
* (edit)
src/main/java/org/apache/joshua/decoder/hypergraph/OutputStringExtractor.java
* (edit)
src/main/java/org/apache/joshua/decoder/ff/lm/bloomfilter_lm/BloomFilterLanguageModel.java
* (edit) src/main/java/org/apache/joshua/decoder/phrase/Coverage.java
* (edit)
src/main/java/org/apache/joshua/decoder/ff/tm/hash_based/ExtensionIterator.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/tm/CreateGlueGrammar.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/tm/GrammarReader.java
* (edit) src/main/java/org/apache/joshua/decoder/Decoder.java
* (edit)
src/main/java/org/apache/joshua/decoder/ff/tm/format/MosesFormatReader.java
* (edit) src/main/java/org/apache/joshua/decoder/phrase/Hypothesis.java
* (edit) src/main/java/org/apache/joshua/decoder/phrase/PhraseChart.java
* (edit) src/main/java/org/apache/joshua/decoder/ArgsParser.java
* (edit) src/main/java/org/apache/joshua/decoder/BLEU.java
* (edit)
src/main/java/org/apache/joshua/decoder/ff/lm/bloomfilter_lm/BloomFilter.java
* (edit)
src/main/java/org/apache/joshua/decoder/chart_parser/ComputeNodeResult.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/fragmentlm/Trees.java
* (edit) src/main/java/org/apache/joshua/decoder/phrase/Header.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/fragmentlm/FragmentLMFF.java
* (edit) src/main/java/org/apache/joshua/decoder/Translation.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/LexicalFeatures.java
* (edit) src/main/java/org/apache/joshua/decoder/StructuredTranslation.java
* (edit) src/main/java/org/apache/joshua/decoder/JoshuaConfiguration.java
* (edit)
src/main/java/org/apache/joshua/decoder/hypergraph/ViterbiExtractor.java
* (edit) src/main/java/org/apache/joshua/decoder/chart_parser/Chart.java
* (edit) src/main/java/org/apache/joshua/decoder/phrase/PhraseTable.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/TargetBigram.java
* (edit) src/main/java/org/apache/joshua/decoder/phrase/Candidate.java
* (edit) src/main/java/org/apache/joshua/decoder/phrase/Stacks.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/SourcePathFF.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/lm/buildin_lm/TrieLM.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/FeatureVector.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/LabelCombinationFF.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/RuleShape.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/tm/OwnerMap.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/tm/Rule.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/lm/KenLM.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/PhraseModel.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/phrase/Distortion.java
* (edit) src/main/java/org/apache/joshua/decoder/segment_file/Sentence.java
* (edit) src/main/java/org/apache/joshua/decoder/NbestMinRiskReranker.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/fragmentlm/Tree.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/tm/AbstractGrammar.java
* (edit)
src/main/java/org/apache/joshua/decoder/ff/tm/hash_based/MemoryBasedBatchGrammar.java
* (edit)
src/main/java/org/apache/joshua/decoder/ff/tm/SentenceFilteredGrammar.java
* (edit) src/main/java/org/apache/joshua/decoder/DecoderThread.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/lm/LanguageModelFF.java
* (edit) src/main/java/org/apache/joshua/decoder/io/JSONMessage.java
* (edit) src/main/java/org/apache/joshua/decoder/chart_parser/Cell.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/RulePropertiesQuerying.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/LabelSubstitutionFF.java
* (edit)
src/main/java/org/apache/joshua/decoder/ff/fragmentlm/PennTreebankReader.java
* (edit) src/main/java/org/apache/joshua/decoder/phrase/Stack.java
* (edit) src/main/java/org/apache/joshua/decoder/chart_parser/DotChart.java
* (edit)
src/main/java/org/apache/joshua/decoder/hypergraph/AlignedSourceTokens.java
* (edit)
src/main/java/org/apache/joshua/decoder/chart_parser/CubePruneState.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/PhrasePenalty.java
* (edit) src/main/java/org/apache/joshua/decoder/hypergraph/HGNode.java
* (edit)
src/main/java/org/apache/joshua/decoder/hypergraph/WordAlignmentExtractor.java
* (edit)
src/main/java/org/apache/joshua/decoder/chart_parser/StateConstraint.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/tm/BasicRuleCollection.java
* (edit)
src/main/java/org/apache/joshua/decoder/hypergraph/DefaultInsideOutside.java
* (edit)
src/main/java/org/apache/joshua/decoder/ff/similarity/EdgePhraseSimilarityFF.java
* (edit) src/main/java/org/apache/joshua/decoder/hypergraph/HyperEdge.java
* (edit) src/main/java/org/apache/joshua/decoder/hypergraph/KBestExtractor.java
* (edit)
src/main/java/org/apache/joshua/decoder/segment_file/ConstraintRule.java
* (edit)
src/main/java/org/apache/joshua/decoder/StructuredTranslationFactory.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/tm/packed/PackedGrammar.java
* (edit)
src/main/java/org/apache/joshua/decoder/ff/tm/packed/SliceAggregatingTrie.java
* (edit)
src/main/java/org/apache/joshua/decoder/ff/state_maintenance/NgramDPState.java
* (edit) src/main/java/org/apache/joshua/decoder/hypergraph/AllSpansWalker.java
* (edit)
src/main/java/org/apache/joshua/decoder/hypergraph/HyperGraphPruning.java
* (edit) src/main/java/org/apache/joshua/decoder/hypergraph/ForestWalker.java
* (edit)
src/main/java/org/apache/joshua/decoder/hypergraph/StringToTreeConverter.java
* (edit)
src/main/java/org/apache/joshua/decoder/io/TranslationRequestStream.java
* (edit) src/main/java/org/apache/joshua/decoder/segment_file/Token.java
* (edit)
src/main/java/org/apache/joshua/decoder/ff/lm/berkeley_lm/LMGrammarBerkeley.java
* (edit) src/main/java/org/apache/joshua/decoder/Translations.java
* (edit) src/main/java/org/apache/joshua/decoder/chart_parser/SuperNode.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/FeatureFunction.java
* (edit)
src/main/java/org/apache/joshua/decoder/hypergraph/WordAlignmentState.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/OOVPenalty.java
* (edit) src/main/java/org/apache/joshua/decoder/ff/RuleFF.java
* (edit)
src/main/java/org/apache/joshua/decoder/ff/fragmentlm/ConcatenationIterator.java
* (edit) src/main/java/org/apache/joshua/decoder/phrase/Future.java
* (edit)
src/main/java/org/apache/joshua/decoder/hypergraph/GrammarBuilderWalkerFunction.java
* (edit) src/main/java/org/apache/joshua/decoder/chart_parser/SourcePath.java
* (edit) src/main/java/org/apache/joshua/decoder/hypergraph/HyperGraph.java
JOSHUA-291 - added missing import in StructuredTranslation (tommaso: rev
2b570d2b6ca7ad54e1cd6ed09fec58919efc59ce)
* (edit) src/main/java/org/apache/joshua/decoder/StructuredTranslation.java
> Improve code quality via static analysis
> ----------------------------------------
>
> Key: JOSHUA-291
> URL: https://issues.apache.org/jira/browse/JOSHUA-291
> Project: Joshua
> Issue Type: Improvement
> Components: core
> Reporter: Tommaso Teofili
> Assignee: Tommaso Teofili
>
> We can improve code quality / readability leveraging code analysis from tools
> like FindBugs and others integrated in IDEs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
