Github user fhieber commented on the pull request: https://github.com/apache/incubator-joshua/commit/d4fdbfd88bab99e244d3ed1fc9cff4ba5e6d124c#commitcomment-18742911 Yes, sounds like the right thing to do. Would there be a way to decide on statefulness earlier to avoid the instanceof checks and adding a new interface method which is redundant for Stateless feature functions? Maybe @KellenSunderland can comment on what the right way to instantiate feature function classes is in general.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---