[
https://issues.apache.org/jira/browse/JOSHUA-293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Post updated JOSHUA-293:
-----------------------------
Fix Version/s: 6.2
> EdgePhraseSimilarityFF suffers from poor design
> -----------------------------------------------
>
> Key: JOSHUA-293
> URL: https://issues.apache.org/jira/browse/JOSHUA-293
> Project: Joshua
> Issue Type: Improvement
> Reporter: Max Thomas
> Priority: Minor
> Fix For: 6.2
>
>
> aside: should a "cleanup" category or similar be used for these?
> EdgePhraseSimilarityFF opens resources that cannot be closed:
> * There is no method that attempts to clean up or close the resources opened
> * There is no implementation of AutoCloseable or similar to indicate that
> resources need to be closed
> * It is only ever instantiated via reflection, so the interface used will
> never allow the AutoCloseable interface (should it be added) to be seen
> Additionally, it tries to read a host/port from configuration, but this will
> always fail if a second object is invoked with the exact same config as the
> socket will be in use already. It explicitly overrides Cloneable, however,
> which is odd, given that it will almost certainly fail.
> Perhaps the functionality desired with the socket and readers should be moved
> to another class that takes in an EdgePhraseSimilarityFF object as a
> parameter and properly handles the management of resources.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
