Github user maxthomas commented on a diff in the pull request:
https://github.com/apache/incubator-joshua/pull/42#discussion_r76825646
--- Diff:
src/main/java/org/apache/joshua/decoder/ff/lm/buildin_lm/TrieLM.java ---
@@ -264,66 +215,65 @@ public static void main(String[] args) throws
IOException {
int n = Integer.valueOf(args[2]);
LOG.info("N-gram order will be {}", n);
- Scanner scanner = new Scanner(new File(args[1]));
+ try (Scanner scanner = new Scanner(new File(args[1]));) {
--- End diff --
I personally prefer the semicolon:
* it's necessary if other statements/resources are added to the autoclose
block
* it's easier to determine the actual method call when there are many
parens towards the end
but I don't mind either way.
What would be nice is a commit that applies the format across the entire
project. A ton of lines have trailing whitespace or tabs or whatever. I'n going
to file an issue on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
