Github user tteofili commented on a diff in the pull request:

    https://github.com/apache/incubator-joshua/pull/69#discussion_r81326566
  
    --- Diff: src/main/java/org/apache/joshua/decoder/package-info.java ---
    @@ -23,4 +23,7 @@
      * of any actual decoding algorithm. Rather, such code is in 
      * child packages of this package.
      */
    -package org.apache.joshua.decoder;
    \ No newline at end of file
    +@Version("0.1.0")
    +package org.apache.joshua.decoder;
    +
    +import org.osgi.annotation.versioning.Version;
    --- End diff --
    
    Sure, creating a separate module for OSGi sounds good to me. Note however 
that the annotation dependency is at compile time, that shouldn't be needed at 
runtime,


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to