[ 
https://issues.apache.org/jira/browse/JOSHUA-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561829#comment-15561829
 ] 

ASF GitHub Bot commented on JOSHUA-290:
---------------------------------------

Github user tteofili commented on a diff in the pull request:

    https://github.com/apache/incubator-joshua/pull/69#discussion_r82572784
  
    --- Diff: src/main/java/org/apache/joshua/decoder/package-info.java ---
    @@ -23,4 +23,7 @@
      * of any actual decoding algorithm. Rather, such code is in 
      * child packages of this package.
      */
    -package org.apache.joshua.decoder;
    \ No newline at end of file
    +@Version("0.1.0")
    +package org.apache.joshua.decoder;
    +
    +import org.osgi.annotation.versioning.Version;
    --- End diff --
    
    sounds good to me, I'll close this one and create a new PR for merging into 
7 branch.


> Provide Joshua artifact as a bundle
> -----------------------------------
>
>                 Key: JOSHUA-290
>                 URL: https://issues.apache.org/jira/browse/JOSHUA-290
>             Project: Joshua
>          Issue Type: Task
>          Components: build
>            Reporter: Tommaso Teofili
>            Assignee: Tommaso Teofili
>
> I think it'd be good if we could make the Joshua artifact an OSGi _bundle_.
> This would have no impact on plain java applications but would give the 
> following benefits:
> - make it possible to install it in OSGi environments
> - optionally introduce semantic versioning (in addition with the baseline 
> plugin) that would help track e.g. if changes in APIs break backward 
> compatibility 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to