Minor optimizations with Map.entrySet
-------------------------------------
Key: JRUBY-3640
URL: http://jira.codehaus.org/browse/JRUBY-3640
Project: JRuby
Issue Type: Improvement
Affects Versions: JRuby 1.2
Environment: OS X 10.5.5 (Should be irrelevant)
Reporter: Ben Kirzhner
Assignee: Thomas E Enebo
Priority: Trivial
Fix For: JRuby 1.2
Attachments: Archive.zip
I ran FindBugs (http://findbugs.sourceforge.net/) over JRuby 1.2.0 for a school
project, and found a few cases in the codebase where, while iterating over
key/value pairs in a map, an iterator is created over the keySet of a map
instead of the entrySet, with a subsequent map.get(key) call. I have made
these (admittedly very minor) changes to three source files:
org.jruby.RubyHash
org.jruby.java.proxies.JavaProxy
org.jruby.yaml.JRubyConstructor
I have uploaded a .zip file with the modified files.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
