Hi,
Just coming up for air, thought I'd throw what might seem a random question
into
the group, as I'm working on a WikiPageProvider implementation.
It appears that the movePage() method makes absolutely no checks prior to
moving (renaming) a wiki page. In other words, moving/renaming a page to
the
name of an already-existing page will clobber that existing page. There's in
the existing code no check, nor even any feedback, as the method returns
void.
Here's the code from the FileSystemProvider:
public void movePage( String from, String to )
throws ProviderException
{
File fromPage = findPage( from );
File toPage = findPage( to );
fromPage.renameTo( toPage );
}
I thought I might throw a ProviderException if the page existed but that
seems
contrary to existing practice. Am I missing something here? Should we
consider
changing the API and/or the documentation (and therefore the
implementations)?
Ichiro
PS. And don't get me started on the deletePage() and deleteVersion()
methods...
And attachments? Yuck.
