[ 
https://issues.apache.org/jira/browse/JSPWIKI-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14742722#comment-14742722
 ] 

Dave Koelmeyer commented on JSPWIKI-905:
----------------------------------------

Thanks Dirk, the previous header spacing better for my needs. While the HADDOCK 
default spacing may look okay, it's a slight step backwards in legibility – but 
I don't think we'll get agreement on this without more people other than you 
and me testing and giving feedback. 

While the workaround CSS works fine (nice to know its easy to alter the CSS in 
this way) I would simply mention in general to consider the defaults 
out-of-the-box. What might work great for bootstrap might not be ideal for 
JSPWiki as a default in some cases without some additional styling. 

Thanks for all your hard work!
Dave

> HADDOCK – headings have insufficient padding
> --------------------------------------------
>
>                 Key: JSPWIKI-905
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-905
>             Project: JSPWiki
>          Issue Type: Improvement
>          Components: Templates and UI
>    Affects Versions: 2.10.2
>         Environment: Client is: 
> - Firefox 39 (Ubuntu 14.04). 
> Server is:
> - JSPWiki v2.10.2-svn-25 running in GlassFish v4
> - Container managed authentication is enabled using a file-based realm
> - HTTPS is enabled
> - JSPWiki policy is locked down such that only authenticated users have 
> access (both read and write)
>            Reporter: Dave Koelmeyer
>         Attachments: HADDOCK-HeadingPadding-1.png, 
> HADDOCK-HeadingPadding-2.png, HADDOCK-HeadingPadding-3.png, 
> HADDOCK-HeadingPadding-4.png, pagesource.txt
>
>
> I've noticed that when applying the HADDOCK template to an existing wiki 
> which has hitherto been using PlainVanilla, main section headings appear to 
> be bunched up to the point where legibility is impacted negatively.
> I've been compensating for this by manually inserting line breaks, but it 
> occurs to me this should really be handled by HADDOCK, rather than manually 
> reformatting. If one ever has to switch back to PlainVanilla for example, 
> then there is a whole lot of associated manual reformatting to do as well.
> After doing some digging around with Firefox inspector, it appears HADDOCK 
> heading elements  (h1, h2, h3) are missing padding values compared to their 
> equivalents in PlainVanilla. This should be amended such that users can apply 
> the HADDOCK template to an existing wiki without readability taking a step 
> back. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to