[
https://issues.apache.org/jira/browse/JSPWIKI-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15778361#comment-15778361
]
Harry Metske commented on JSPWIKI-1035:
---------------------------------------
I fixed all unit tests and removed allmost all occurrences baseURL.
A few notes:
* we can no longer test for the absence of jspwiki baseURL, decide it is the
first install and present Install.jsp (the user has to go explicitly to
Install.jsp as mentioned in the docs). If you have other ways to detect a first
install, please tell us. See commit:
* if we Release this, we have to update our wiki too and remove baseURL there
* I have not tested JSPWiki portable, [~sgoes...@apache.org] could you do that?
* I took the liberty to put this new version on
https://jspwiki-wiki.apache.org/ (ultimate own dogfood eating)
I will create also a new Dockerized version of JSPWiki without this baseURL
setting.
Let me know any comments.
> get rid of jspwiki.baseURL
> --------------------------
>
> Key: JSPWIKI-1035
> URL: https://issues.apache.org/jira/browse/JSPWIKI-1035
> Project: JSPWiki
> Issue Type: Improvement
> Components: Core & storage
> Affects Versions: 2.10.2
> Reporter: Jürgen Weber
> Attachments: DefaultURLConstructor.java.patch, WikiEngine.java.patch,
> jspwiki.properties.patch
>
>
> Could we get rid of jspwiki.baseURL and calculate it on
> HttpServletRequest#getContextPath() ?
> It's the only mandatory property you have to set for JSPWiki, so removing it
> would make installation much easier.
> And, first and foremost, it makes JSPWiki only work on exactly this URL, i.e.
> you cannot use the same JSPWiki instance in an intranet and on the internet
> (e.g. wiki.firm.com and wiki.firm.private), neither with and without JK'ed
> Apache, neither SSL and non-SSL.
> If you look at the source of https://jspwiki-wiki.apache.org/
> there are not many places where the whole base url is used. So, I wonder, if
> context relative links could be sufficient.
> http://stackoverflow.com/questions/4764405/how-to-use-relative-paths-without-including-the-context-root-name
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
