Hi,
just committed the fix and it has already passed that module so, at least!
I'll try to set up the release during the weekend, so the vote for
2.11.0-M4 can start next Monday-ish.
thanks + best regards,
juan pablo
On Fri, May 10, 2019 at 12:50 AM Murray Altheim <murra...@altheim.com>
wrote:
> Hi Juan Pablo,
>
> My apologies, but I've not yet sorted out my Apache account, so I
> can't commit.
>
> But here's the fixed test:
>
> @Test
> void testGetAttachmentContent() throws Exception
> {
> engine.saveText("Test-tika", "blablablabla");
> byte[] filePdf =
> Files.readAllBytes(Paths.get(TikaSearchProviderTest.class.getClassLoader().getResource("aaa-diagram.pdf").toURI()));
> byte[] filePng =
> Files.readAllBytes(Paths.get(TikaSearchProviderTest.class.getClassLoader().getResource("favicon.png").toURI()));
> engine.addAttachment("Test-tika", "aaa-diagram.pdf", filePdf);
> engine.addAttachment("Test-tika", "favicon.png", filePng);
>
> TikaSearchProvider tsp =
> (TikaSearchProvider)engine.getSearchManager().getSearchEngine();
>
> Attachment attPdf =
> engine.getAttachmentManager().getAttachmentInfo("Test-tika/aaa-diagram.pdf");
> String pdfIndexed = tsp.getAttachmentContent(attPdf);
> Assertions.assertTrue(pdfIndexed.contains("aaa-diagram.pdf"));
>
> Assertions.assertTrue(pdfIndexed.contains("WebContainerAuthorizer"));
>
> Attachment attPng =
> engine.getAttachmentManager().getAttachmentInfo("Test-tika/favicon.png");
> String pngIndexed = tsp.getAttachmentContent(attPng);
> Assertions.assertTrue(pngIndexed.contains("favicon.png"));
> }
>
> This is the kind of thing I often see on OS-heterogenous teams, where
> until a Linux box tests positive, the project is probably not truly
> tested, as the Windows devs don't sometimes see case-sensitive or file
> path errors.
>
> I believe I once didn't get a job offer after an otherwise successful
> interview when the team leader thought I was being disruptive by
> suggesting I develop on Linux (my native environment), even after I
> explained that if the project deploys to Linux it's a good idea to
> have at least one or two Linux devs. Management wanted a Windows-only
> environment. I'm probably happier not getting that job, but it seems
> common.
>
> Cheers,
>
> Murray
>
> On 10/05/19 10:34 AM, Juan Pablo Santos Rodríguez wrote:
> > howdy! thanks for spotting that!! would you mind committing the fix to
> > master? I'll have a look tomorrow on
> > why/where the page name has its first letter upper-cased, but this should
> > be enough for beginning the release
> > of 2.11.0-M4..
> >
> > thx again + br,
> > juan pablo
> ...........................................................................
> Murray Altheim <murray18 at altheim dot com> = = ===
> http://www.altheim.com/murray/ ===
> ===
> = =
> ===
> In the evening
> The rice leaves in the garden
> Rustle in the autumn wind
> That blows through my reed hut.
> -- Minamoto no Tsunenobu
>
>
