Hi, after more than 72 hours, the vote tally goes with 4 +1, from * Murray Altheim * Dirk Frederickx * Harry Metske * Juan Pablo Santos (* denoting PMC member, thus binding)
with no other votes cast, so the vote passes. I'll proceed with the release during tonight/tomorrow Thanks to all who voted! best regards, juan pablo On Sat, Dec 14, 2019 at 1:05 PM Dirk Frederickx <dirk.frederi...@gmail.com> wrote: > Juan, > > Sorry, I double checked my installation and you are correct. > Apparently I didn't take the latest rss.jsp which was indeed modified on > 6/dec. > > Txs for preparing the build. > You have my +1 > > > BR, > dirk > > On Sat, Dec 14, 2019 at 12:45 PM Juan Pablo Santos Rodríguez < > juanpablo.san...@gmail.com> wrote: > > > Hi Dirk, > > > > cannot reproduce the issue with a clean checkout on a fresh environment > > (using the cargo plugin); rss.jsp is using the method from TextUtil, > > this was made on > > > > > https://github.com/apache/jspwiki/commit/950a64c24c356f5c1b1eefec63f0f22943b3702e#diff-2a02bcb668c525ff9cbb40edb0e85729 > > Also, the JSP precompilation plugin doesn't yield anything, so if > present, > > it would've breaked the CI builds at builds.apache.org. > > > > If you have you tested over an existing installation on a tomcat instance > > maybe the are old, precompiled JSPs lurking on > > $TOMCAT/work/[...]/JSPWiki ? Don't know what else could cause the issue > :-? > > Are you able to run the integration tests > > (mvn clean install -Pintegration-tests)? > > > > > > best regards, > > juan pablo > > > > On Sat, Dec 14, 2019 at 10:33 AM Dirk Frederickx < > > dirk.frederi...@gmail.com> > > wrote: > > > > > Juan > > > > > > Looks good. > > > But I've seen one issue on RSS.JSP related to the change of > > > getRequiredProperty() > > > (test: click page rss feed link in INFO dropdown; give jsp > compilation > > > error) > > > > > > -1 > > > > > > dirk > > > > > > > > > On Sat, Dec 14, 2019 at 8:14 AM Murray Altheim <murra...@altheim.com> > > > wrote: > > > > > > > +1, looks good. > > > > > > > > On 14/12/19 4:38 AM, Harry Metske wrote: > > > > > +1 > > > > > > > > > > thanks, > > > > > Harry > > > > > > > > > > > > > > > On Thu, 12 Dec 2019 at 22:14, Juan Pablo Santos Rodríguez < > > > > > juanpa...@apache.org> wrote: > > > > > > > > > >> This is a release vote for Apache JSPWiki, version 2.11.0.M6. The > > vote > > > > will > > > > >> be open for at least 72 hours from now. > > > > >> > > > > >> It fixes the following issues: > > > > >> > > > > >> > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310732&version=12346489 > > > > >> > > > > >> You can see a curated changelog at > > > > >> https://jspwiki-wiki.apache.org/Wiki.jsp?page=NewIn2.11 > > > > >> > > > > >> Note that we are voting upon the source (tag), binaries are > provided > > > for > > > > >> convenience. > > > > >> > > > > >> Everybody is encouraged to vote. > > > > >> > > > > >> Source and binary files: > > > > >> https://dist.apache.org/repos/dist/dev/jspwiki/2.11.0.M6-rc1 > > > > >> > > > > >> Nexus staging repo: > > > > >> > > > > > > https://repository.apache.org/content/repositories/orgapachejspwiki-1016 > > > > >> > > > > >> The tag to be voted upon: > > > > >> https://github.com/apache/jspwiki/tree/2.11.0.M6-RC1 > > > > >> > > > > >> JSPWiki's KEYS file containing PGP keys we use to sign the > release: > > > > >> https://www.apache.org/dist/jspwiki/KEYS > > > > >> > > > > >> *** Please download, test and vote: > > > > >> > > > > >> [ ] +1 Approve the release > > > > >> [ ] 0 Don't mind > > > > >> [ ] -1 Disapprove the release (please provide specific comments) > > > > >> > > > > > > > > > > > > > -- > > > > > > > > > > > > > > ........................................................................... > > > > Murray Altheim <murray18 at altheim dot com> = > = > > > === > > > > http://www.altheim.com/murray/ > === > > > > === > > > > > = = > > > > === > > > > In the evening > > > > The rice leaves in the garden > > > > Rustle in the autumn wind > > > > That blows through my reed hut. > > > > -- Minamoto no Tsunenobu > > > > > > > > > > > > > >
