Hi Murray, I'll look into make the current plugins mantain their signature if possible. As I wrote else-thread, keep in mind the 6 last releases contain code changes that could result in custom plugins / filters not working anymore. That would also happen on this release, whether the plugin signature changes or not. What I wouldn't want to do is to include back code that would make [#1] back into [#2]..
best regards, juan pablo [#1]: https://jspwiki-wiki.apache.org/attach/JSPWiki3APIDesignProposal/highwheel-master.png [#2]: https://jspwiki-wiki.apache.org/attach/JSPWiki3APIDesignProposal/highwheel-2.11.0.M6-reduced.png (original image resulted in 36MB, have to scale it to keep the size reasonable, to see the full details is better to execute the maven plugin..) On Sat, Mar 7, 2020 at 4:21 AM Murray Altheim <murra...@altheim.com> wrote: > > > Hi Murray, > > > > for plugins, most probably there'll be a signature change on WikiPlugin, > > from: > > String execute( WikiContext context, Map< String, String > params ) > throws > > PluginException; > > > > to: > > String execute( Context context, Map< String, String > params ) throws > > PluginException; > > Hi Juan Pablo, > > I realise you can't promise anything, but what I'm asking is that there > be an adapter-pattern package that maintains **exactly** the same > signature as the existing plugins, if at all possible. If we require people > to re-code and ecompile plugins then in many cases they simply won't > upgrade JSPWiki, as in many cases they won't have time, don't have > the developer time or experience or personnel available, etc. as I > mentioned previously. > > If the changes proposed as part of this public API are merely changes > of name and package location (effectively facades over the existing > code), then an adapter package should be possible. If not, I can't say > I'd advocate for making such a change as I believe it would segregate > existing users into two camps: those able to re-code and re-install an > update, and those who can't due to existing plugins. That seems an > overly high price for the existence of a new public API that doesn't > add functionality, i.e., if we don't provide a compatible bridging adapter > package. > > Cheers, > > Murray > > ........................................................................... > Murray Altheim <murray18 at altheim dot com> = = === > http://www.altheim.com/murray/ === > === > = = === > In the evening > The rice leaves in the garden > Rustle in the autumn wind > That blows through my reed hut. > -- Minamoto no Tsunenobu > > > >
