thanks for following up, I will delete that (my personal) repo to prevent future misunderstandings.
cheers, Harry On Mon, 21 Dec 2020 at 17:36, Carl Marcum <cmar...@apache.org> wrote: > Hi Juan Pablo, > > Thanks for redirect. That's quite a bit different. > I will fork that repo instead and work on it. > > If I see something I think will help I'll be back :) > > Best regards, > Carl > > On 12/21/20 11:17 AM, Juan Pablo Santos Rodríguez wrote: > > Hi Carl, > > > > the Dockerfile was moved on to the main repo on 2.11.0.M6, you cand > > find it at [#1]. Related documentation at jspwiki-wiki.a.o [#2] is > > still outdated, tough, and needs some work to reflect current status. > > > > In any case, we'd love if you could take a look at [#1] and send any > > PRs you see fit to make it better! :-) > > > > > > Thanks + best regards, > > juan pablo > > > > > > [#1]: https://github.com/apache/jspwiki/blob/master/Dockerfile > > <https://github.com/apache/jspwiki/blob/master/Dockerfile> > > [#2]: https://jspwiki-wiki.apache.org/Wiki.jsp?page=Docker > > <https://jspwiki-wiki.apache.org/Wiki.jsp?page=Docker> > > > > On Mon, Dec 21, 2020 at 2:23 PM Carl Marcum <cmar...@apache.org > > <mailto:cmar...@apache.org>> wrote: > > > > Hi All, > > > > I've forked the docker-jspwiki [1] from github and was wondering > > if you > > might want anything I'm working on PR'd back. > > > > Some of the things I'm looking at are: > > > > 1. Using the Dockerfile to download binaries and remove them. > > > > I noticed the Docker file comments mention CentOS 7 but the image is > > Alpine so I didn't know if that was a planned change. > > 2. a. Using a CentOS based image and adding a JRE > > b. Amazon Corretto based on Amazon Linux 2 optimized for AWS. > > c. Just start with an official Tomcat image (many OS options with > > this one). > > > > 3. Reducing the number of image layers through command consolidation. > > > > Also is branch 2.11.0-M5 the latest branch? > > > > Thanks, > > Carl > > > > [1] https://github.com/metskem/docker-jspwiki > > <https://github.com/metskem/docker-jspwiki> > > > > Best regards, > > Carl > > > >
