arturobernalg commented on pull request #47:
URL: https://github.com/apache/jspwiki/pull/47#issuecomment-926032053


   > Hi @arturobernalg ,
   > 
   > apologies for the long delay looking at this PR. I'm +1 on merging it, 
however, would you mind pls rebasing with latest commits?
   > 
   > As for the signature change, that method is package-protected and seems to 
be used only by the `loadWebAppProps` method on the same class, and handled by 
its `try..catch` block, so it shouldn't be a big deal..
   > 
   > best regards,
   > juan pablo
   
   HI @juanpablo-santos , rebase from master. I think all the changes are 
already made previously.
   TY


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to