juanpablo-santos commented on a change in pull request #141:
URL: https://github.com/apache/jspwiki/pull/141#discussion_r734485617
##########
File path: jspwiki-main/src/main/java/org/apache/wiki/WikiSession.java
##########
@@ -388,7 +388,7 @@ public void invalidate() {
* This method should generally be called after a user's {@link
org.apache.wiki.auth.user.UserProfile} is saved. If the wiki session
* is null, or there is no matching user profile, the method returns
silently.
*/
- protected void injectGroupPrincipals() {
+ void injectGroupPrincipals() {
Review comment:
`protected` should also be retained here.
##########
File path: jspwiki-main/src/main/java/org/apache/wiki/WikiSession.java
##########
@@ -406,7 +406,7 @@ protected void injectGroupPrincipals() {
* and login name. These Principals will be WikiPrincipals, and they will
replace all other WikiPrincipals in the Subject. <em>Note:
* this method is never called during anonymous or asserted sessions.</em>
*/
- protected void injectUserProfilePrincipals() {
+ void injectUserProfilePrincipals() {
Review comment:
`protected` should also be retained here.
##########
File path:
jspwiki-main/src/main/java/org/apache/wiki/ui/DefaultCommandResolver.java
##########
@@ -325,7 +325,7 @@ public Page resolvePage( final HttpServletRequest request,
String page ) {
* @throws ProviderException if the underlyng page provider that locates
pages
* throws an exception
*/
- protected boolean simplePageExists( final String page ) throws
ProviderException {
+ boolean simplePageExists( final String page ) throws ProviderException {
Review comment:
`protected` should also be retained here.
As of last comment here, `DefaultCommandResolver` isn't instantiated
directly, but obtained through `Engine#getManager( Class<?> )`. Previous
versions of JSPWiki were returning specifically `DefaultCommandResolver`, but
nowadays we're returning a `CommandResolver` (an interface extracted from the
former class), so it is possible to [provide an alternative
implementation](https://jspwiki-wiki.apache.org/Wiki.jsp?page=JSPWikiPublicAPI#section-JSPWikiPublicAPI-RegisteringCustomManagersInTheWikiEngine).
Hence, in order to allow reuse, it makes more sense to remove the `final`
class modifier, rather than removing the `protected` modifier. Doing this
should be really uncommon, but you never know..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
