[ 
https://issues.apache.org/jira/browse/JSPWIKI-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Juan Pablo Santos Rodríguez resolved JSPWIKI-1156.
--------------------------------------------------
    Resolution: Fixed

merged in 2.11.0-git-12, thanks!

> Remove 'protected' member in 'final' class
> ------------------------------------------
>
>                 Key: JSPWIKI-1156
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-1156
>             Project: JSPWiki
>          Issue Type: Improvement
>            Reporter: Arturo Bernal
>            Priority: Minor
>              Labels: pull-request-available
>
> Since final classes cannot be inherited, marking the method as protected may 
> be confusing. 
> IMO It is better to declare such members as private or package-visible 
> instead.
>  
> Of course I can be wrong.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to