[ https://issues.apache.org/jira/browse/JSPWIKI-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ASF GitHub Bot updated JSPWIKI-388: ----------------------------------- Labels: pull-request-available (was: ) > ParamTag loops forever when parent tag is not ParamHandler > ---------------------------------------------------------- > > Key: JSPWIKI-388 > URL: https://issues.apache.org/jira/browse/JSPWIKI-388 > Project: JSPWiki > Issue Type: Bug > Components: Core & storage > Affects Versions: 2.6.3 > Reporter: Simon Kitching > Priority: Major > Labels: pull-request-available > > I recently tried to use tag wiki:Param within a wiki:UploadLink tag, and the > page immediately hung. It appears that this combination is not supported > (ok), but the infinite loop is presumably not intended. > The problem is with this code in class ParamTag: > public int doEndTag() > { > Tag t = null; > while( (t = getParent()) != null && !(t instanceof ParamHandler) ) > ; > ... > } > This code is the same in both jspwiki 2.6.3 (which I am using) and current > svn trunk. > This loops endlessly if the parent of the ParamTag is not a ParamHandler, > because getParent() returns the same object each time. Maybe t.getParent() > was intended? (although that won't work on the first call when t is null). -- This message was sent by Atlassian Jira (v8.20.10#820010)