spyhunter99 commented on code in PR #232:
URL: https://github.com/apache/jspwiki/pull/232#discussion_r2505192976
##########
jspwiki-util/src/main/java/org/apache/wiki/util/FileUtil.java:
##########
@@ -108,8 +108,8 @@ public static String runSimpleCommand( final String
command, final String direct
final StringBuilder result = new StringBuilder();
final Process process = Runtime.getRuntime().exec( command, null, new
File( directory ) );
- try( final BufferedReader stdout = new BufferedReader( new
InputStreamReader( process.getInputStream() ) );
- final BufferedReader stderr = new BufferedReader( new
InputStreamReader( process.getErrorStream() ) ) ) {
+ try( final BufferedReader stdout = new BufferedReader( new
InputStreamReader( process.getInputStream(), StandardCharsets.UTF_8 ) );
Review Comment:
honestly it should probably all be standardized on utf8. is there a reason
for this specific setup to use (basically) ascii? we have a ton of
internationalization code within jspwiki, this just seems a bit off
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
