spyhunter99 commented on code in PR #429:
URL: https://github.com/apache/jspwiki/pull/429#discussion_r2529138991
##########
jspwiki-event/src/main/java/org/apache/wiki/event/WikiEvent.java:
##########
@@ -42,14 +44,20 @@ public abstract class WikiEvent extends EventObject {
/** objects associated to src which only make sense in the context of a
given WikiEvent */
private Object[] args;
+
+ private Map<Object,Object> attributes = new HashMap<>();
Review Comment:
javadocs
##########
jspwiki-event/src/main/java/org/apache/wiki/event/WikiEvent.java:
##########
@@ -42,14 +44,20 @@ public abstract class WikiEvent extends EventObject {
/** objects associated to src which only make sense in the context of a
given WikiEvent */
private Object[] args;
+
+ private Map<Object,Object> attributes = new HashMap<>();
+
+ public Map<Object, Object> getAttributes() {
Review Comment:
javadocs
##########
jspwiki-event/src/main/java/org/apache/wiki/event/WikiEventManager.java:
##########
@@ -127,7 +127,7 @@ public final class WikiEventManager {
private static final Logger LOG =
LogManager.getLogger(WikiEventManager.class);
/* If true, permits a WikiEventMonitor to be set. */
- private static final boolean c_permitMonitor = false;
+ private static final boolean c_permitMonitor = true;
Review Comment:
for discussion. i'm not 100% sure what other effects this will have for
enabling this but it was required to get a global listener working. the
eventing system i'm still a bit unsure why it is like it is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
