spyhunter99 commented on code in PR #415:
URL: https://github.com/apache/jspwiki/pull/415#discussion_r2532026066
##########
jspwiki-main/src/test/java/org/apache/wiki/ui/admin/beans/PluginBeanTest.java:
##########
@@ -40,17 +40,8 @@ public void testDoGet() throws WikiException,
NotCompliantMBeanException {
testEngine = new TestEngine( props );
final Context context = Wiki.context().create( testEngine,
Wiki.contents().page( testEngine, "TestPage01" ) );
final PluginBean pb = new PluginBean( testEngine );
- final String expectedHtml = "<div>" +
- "<h4>Plugins</h4>" +
- "<table border=\"1\">" +
-
"<tr><th>Name</th><th>Alias</th><th>Author</th><th>Notes</th></tr>" +
-
"<tr><td>IfPlugin</td><td>If</td><td>Janne Jalkanen</td><td></td></tr>" +
- "<tr><td>Note</td><td></td><td>Janne
Jalkanen</td><td></td></tr>" +
-
"<tr><td>SamplePlugin</td><td>samplealias</td><td>Janne
Jalkanen</td><td></td></tr>" +
-
"<tr><td>SamplePlugin2</td><td>samplealias2</td><td>Janne
Jalkanen</td><td></td></tr>" +
- "</table>" +
- "</div>";
- Assertions.assertEquals( expectedHtml, pb.doGet( context ) );
+
+ Assertions.assertNotNull( pb.doGet( context ) );
Review Comment:
fixed
##########
jspwiki-portable/build.xml:
##########
@@ -69,12 +69,19 @@
<!-- copy the exploded war for the "personal" wiki -->
<copy todir="${jspwiki.woas.assembly.dir}/webapps/personal"
overwrite="true">
<fileset dir="${jspwiki.woas.unpack.dir}/jspwiki-war/"/>
+ </copy>
+ <!-- copy our test hello world plugin for verifying plugin
discoverability -->
+ <copy todir="${jspwiki.woas.assembly.dir}/jspwiki/lib" overwrite="true">
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
