arturobernalg opened a new pull request, #542:
URL: https://github.com/apache/jspwiki/pull/542
Renaming a page with "update referrers" only rewrote [links]. A page that
includes the renamed one with [{InsertPage page='X'}], or that is an alias of
it with [{SET alias='X'}], kept the old name and ended up showing "There is no
page called 'X'".
The ReferenceManager has no record of such parameters, so the renamer now
looks for them in the text of every page and rewrites the ones that name the
renamed page. The quoting and the spacing of the original are kept, and escaped
invocations are left alone. Only the page parameter of InsertPage and the alias
parameter of SET are handled.
Looking at every page makes a rename that updates referrers slower on large
wikis.
Tests: 9 new cases in PageRenamerTest (single and double quotes, names with
blanks, other pages and other variables left untouched, referrers not changed,
escaped invocation, the renamed page aliasing itself, spacing). The five that
check the rewrite fail without the change. The jspwiki-util, jspwiki-event and
jspwiki-main suites pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
