arturobernalg opened a new pull request, #548: URL: https://github.com/apache/jspwiki/pull/548
org.codelibs:nekohtml is no longer maintained. This moves to org.htmlunit:neko-htmlunit 5.6.0, which needs Java 17 like the rest of the project. It is only used by jspwiki-wysiwyg, to turn the HTML of the WYSIWYG editor into XHTML; jspwiki-main declared the dependency without using it, so it is dropped there. The line in LICENSE is updated. Changes in HtmlStringToWikiTranslator: - The new parser does not recognise the SAX validation feature that JDOM's XMLReaderSAX2Factory sets, so JDOM is given its own reader factory. - - The new parser reports a null namespace URI for attributes, where SAX says it is the empty string, and JDOM rejects it. The parser is wrapped in a small filter that turns those URIs into empty strings. - - Element names are now lower case, as in XHTML, instead of upper case. The translator already compared names in lower case almost everywhere; the six hard coded upper case names (in XHtmlElementToWikiTranslator and FormDecorator) are lower case now. Tests: no test changes. The 18 tests of HtmlStringToWikiTranslatorTest pass, as before, and so do the suites of jspwiki-util, jspwiki-event, jspwiki-main and jspwiki-markdown. Names with a namespace prefix, such as the o:p of pasted Word content, fail in JDOM both before and after this change. I did not build the WAR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
