[
https://issues.apache.org/jira/browse/JSPWIKI-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18132927#comment-18132927
]
ASF subversion and git services commented on JSPWIKI-1305:
----------------------------------------------------------
Commit 482b373d60e2d677c0bf8e9c2e2a326f7fd8ef45 in jspwiki's branch
refs/heads/master from Arturo Bernal
[ https://gitbox.apache.org/repos/asf?p=jspwiki.git;h=482b373d6 ]
JSPWIKI-1305 Keep the workflows of each engine apart
Workflow events travel through a JVM-wide emitter and each manager attached
itself with WikiEventEmitter.attach, which detaches every other manager of
the same type. With several engines in one JVM (e.g. wikis deployed with a
shared classpath) only the last manager created received the events, so
the approval workflow of one wiki ended up in the decision queue of
another and the actual one was left without it.
Managers now register without evicting the others and ignore the events
that are not about their own workflows. A new Workflow is not tracked yet,
so a constructor taking the Engine is added and its creation event carries
it. WorkflowBuilder uses it; the existing constructor still notifies every
manager.
> The page edit workflow mechanism is not working as expected on multi-instance
> deployments
> -----------------------------------------------------------------------------------------
>
> Key: JSPWIKI-1305
> URL: https://issues.apache.org/jira/browse/JSPWIKI-1305
> Project: JSPWiki
> Issue Type: Bug
> Affects Versions: 3.0.0, 2.12.5
> Reporter: Alex O'Ree
> Priority: Minor
> Labels: pull-request-available
>
> i'm testing another issue using the portable build.
> If i enable the workflow logic by setting
> > jspwiki.approver.workflow.saveWikiPage = Admin
> in jspwiki-custom.proeprties, then restart the server
> sign in as a user account, edit the home page, then i'm redirected to a page
> discussing workflows, etc.
> return to the home page and select workflows. nothing is listed in inbox or
> outbox
> logout and login as an admin user, go to the home page, select workflows.
> again empty inbox and outbox. i've verified this on master for 3.x and master
> for 2.x
>
> EDIT: this is isolated to multi instance deployments with a shared
> classpath... i.e. the portable build with both a department and a personal
> wiki instances. Basically workflow events from one are being cross
> contaminated to the other, effectively breaking the workflow mechanism.
> work around is to a) not have a multi instance deployment how is it deployed
> within the portable build, i.e. have two completely separate instances, no
> shared classpath. or b) have to tomcat instances, etc.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
