[ 
https://issues.apache.org/jira/browse/JSPWIKI-523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18134071#comment-18134071
 ] 

Arturo Bernal commented on JSPWIKI-523:
---------------------------------------

Checked with the current code (master plus an unrelated parser change, Tomcat 
10.1, default URL constructor), by fetching the rendered HTML.

Part 2: a page that inserts EditPageHelp with the InsertPage plugin, where 
EditPageHelp has its own TableOfContents, lists the headings of EditPageHelp 
(Help heading, Help section A, Help section B) and not those of the page that 
inserts it. Opening EditPageHelp alone with the reader skin, which is how the 
default template shows the help now (a link, no longer a tab), gives the same 
list.

Part 1: the links of the table of contents are only anchors, for example 
#section-EditPageHelp-HelpSectionA, as the fix of 2009 made them.

Limits: I did not click through the tabbed template of 2009, the reporter used 
ShortViewURLConstructor and I only tried the default one, and I did not combine 
a page in edit mode with the embedded help. I leave the issue open for someone 
who can confirm on that setup.

> TableOfContents-Plugin on Tabbed HelpPages (eg EditPageHelp)
> ------------------------------------------------------------
>
>                 Key: JSPWIKI-523
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-523
>             Project: JSPWiki
>          Issue Type: Bug
>    Affects Versions: 2.8.2
>         Environment: Red Hat Linux, Sun JDK 1.6.0_07, Tomcat 6.0.16
>            Reporter: Stefan Bohn
>            Priority: Minor
>         Attachments: JSPWiki-523a.patch
>
>
> Two incorrect behaviors of the ToC-Plugin:
> 1) We are using one WikiSyntax page both as standalone page and as 
> EditPageHelp (we use the InsertPage-Plugin here and have no other text on 
> this page).
> The ToC-Plugin generates links as <a class="wikipage" 
> href="/wiki/WikiSyntax#section-WikiSyntax-Links">Links</a>
> When you are editing a page and switch to the help tab, a click on a toc 
> entry results in a reload of the WikiSyntax page and leaving the page that 
> was edited.
> Links that look like <a class="wikipage" 
> href="#section-WikiSyntax-Links">Links</a> (only the anchor) would work like 
> expected.
> 2) If EditHelpPage has its own text and ToC (without InsertPage-Plugin), on 
> the help tab the ToC-Plugin shows the ToC of the edited page.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to